so I take it you're +1, save the below tweaks?
I haven't tested it, but looks ok, i can test it soonish, if you have a cleaned up version that would be better.
attached.
it passes all tests for me with 5.8.0/bleedperl and prefork. 5.8.0/worker is failing t/modperl/method.t with "not a CODE reference" when run as part of the test suite but not when run by itself. I'll look into it some more - I'm not sure if it's related or not, but I haven't tested worker in a while.
I've tried with perl-5.8.0-ithread and I can't see the failure.
I did an extensive smoking with several perl/httpd versions and it seems to be working, other than the 'closure' test in the ModPerl-Registry test suite. but that is a known issue.
In any case if you have a failing test, it's probably a good idea to fix it first before committing the change. Here is the setup that I've used, where I couldn't reproduce it.
*** mod_perl version 1.9910
*** using lib/Apache/BuildConfig.pm *** Makefile.PL options: MP_APXS => /home/stas/httpd/worker/bin/apxs MP_COMPAT_1X => 1 MP_DEBUG => 1 MP_GENERATE_XS => 1 MP_INST_APACHE2 => 1 MP_LIBNAME => mod_perl MP_TRACE => 1 MP_USE_DSO => 1 MP_USE_GTOP =>
*** /home/stas/httpd/worker/bin/httpd -V Server version: Apache/2.0.48-dev Server built: Aug 5 2003 12:05:33 Server's Module Magic Number: 20020903:4 Architecture: 32-bit Server compiled with.... -D APACHE_MPM_DIR="server/mpm/worker" -D APR_HAS_SENDFILE -D APR_HAS_MMAP -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled) -D APR_USE_SYSVSEM_SERIALIZE -D APR_USE_PTHREAD_SERIALIZE -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT -D APR_HAS_OTHER_CHILD -D AP_HAVE_RELIABLE_PIPED_LOGS -D HTTPD_ROOT="/home/stas/httpd/worker" -D SUEXEC_BIN="/home/stas/httpd/worker/bin/suexec" -D DEFAULT_SCOREBOARD="logs/apache_runtime_status" -D DEFAULT_ERRORLOG="logs/error_log" -D AP_TYPES_CONFIG_FILE="conf/mime.types" -D SERVER_CONFIG_FILE="conf/httpd.conf"
*** /home/stas/perl/5.8.0-ithread/bin/perl5.8.0 -V
Summary of my perl5 (revision 5.0 version 8 subversion 0) configuration:
Platform:
osname=linux, osvers=2.4.19-16mdksmp, archname=i686-linux-thread-multi
uname='linux hope.stason.org 2.4.19-16mdksmp #1 smp fri sep 20 16:08:37 cest 2002 i686 unknown unknown gnulinux '
config_args='-des -Dprefix=/home/stas/perl/5.8.0-ithread -Dusethreads -Doptimize=-g -Duseshrplib -Dusedevel'
hint=recommended, useposix=true, d_sigaction=define
usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm',
optimize='-g',
cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -I/usr/include/gdbm'
ccversion='', gccversion='3.2 (Mandrake Linux 9.0 3.2-1mdk)', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=4, prototype=define
Linker and Libraries:
ld='cc', ldflags =' -L/usr/local/lib'
libpth=/usr/local/lib /lib /usr/lib
libs=-lnsl -lgdbm -ldb -ldl -lm -lpthread -lc -lcrypt -lutil
perllibs=-lnsl -ldl -lm -lpthread -lc -lcrypt -lutil
libc=/lib/libc-2.2.5.so, so=so, useshrplib=true, libperl=libperl.so
gnulibc_version='2.2.5'
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic -Wl,-rpath,/home/stas/perl/5.8.0-ithread/lib/5.8.0/i686-linux-thread-multi/CORE'
cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'
Characteristics of this binary (from libperl):
Compile-time options: DEBUGGING MULTIPLICITY USE_ITHREADS USE_LARGE_FILES PERL_IMPLICIT_CONTEXT
Built under linux
Compiled at Nov 28 2002 14:08:29
%ENV:
PERL_LWP_USE_HTTP_10="1"
@INC:
/home/stas/perl/5.8.0-ithread/lib/5.8.0/i686-linux-thread-multi
/home/stas/perl/5.8.0-ithread/lib/5.8.0
/home/stas/perl/5.8.0-ithread/lib/site_perl/5.8.0/i686-linux-thread-multi
/home/stas/perl/5.8.0-ithread/lib/site_perl/5.8.0
/home/stas/perl/5.8.0-ithread/lib/site_perl
.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
