Re: [mp2] t/apache/cookie[2].t test failures

[Steve Hay]

Geoffrey Young wrote:



Steve Hay wrote:

Hi,

The apache/cookie.t and apache/cookie2.t tests also fail on Win32 
(Apache 2.0.47, [EMAIL PROTECTED], mp2 CVS):


[Wed Sep 17 09:48:47 2003] [error] [client 127.0.0.1] Invalid URI in 
request GET TestApache__cookie?header HTTP/1.0


yucko.

try the attached patch. 
Yep - your patch fixes the failures in both those test scripts for me.

Thanks,
- Steve


--Geoff

------------------------------------------------------------------------

Index: t/apache/cookie2.t
===================================================================
RCS file: /home/cvspublic/modperl-2.0/t/apache/cookie2.t,v
retrieving revision 1.1
diff -u -r1.1 cookie2.t
--- t/apache/cookie2.t  23 Aug 2003 02:39:10 -0000      1.1
+++ t/apache/cookie2.t  17 Sep 2003 15:36:00 -0000
@@ -8,13 +8,13 @@
plan tests => 2;
my $module = 'TestApache::cookie2';
-my $location = Apache::TestRequest::module2path($module);
+my $location = '/' . Apache::TestRequest::module2path($module);
my $cookie = 'foo=bar';
t_debug("Testing cookie in PerlResponseHandler");

for (qw/header env/) {
-    t_debug("-- testing cookie from $_");
+    t_debug("-- testing cookie from $location$_");
    my $res = GET "$location?$_", Cookie => $cookie;
    ok t_cmp('bar', $res->content,
Index: t/apache/cookie.t
===================================================================
RCS file: /home/cvspublic/modperl-2.0/t/apache/cookie.t,v
retrieving revision 1.2
diff -u -r1.2 cookie.t
--- t/apache/cookie.t   12 Sep 2003 02:17:12 -0000      1.2
+++ t/apache/cookie.t   17 Sep 2003 15:36:00 -0000
@@ -8,7 +8,7 @@
plan tests => 2;
my $module = 'TestApache::cookie';
-my $location = Apache::TestRequest::module2path($module);
+my $location = '/' . Apache::TestRequest::module2path($module);
my $val = "bar";
my $cookie = "key=$val";
@@ -19,6 +19,7 @@
);
for (qw/header env/) {
+    t_debug("-- testing cookie from $location?$_");
    my $received = GET_BODY_ASSERT "$location?$_", Cookie => $cookie;
    ok t_cmp($expected{$_}, $received);
}


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]