-my $location = Apache::TestRequest::module2path($module);
+my $location = '/' . Apache::TestRequest::module2path($module);


The module2path is really there because of win32, which doesn't like paths like /TestApache::cookie. But since we already provide a wrapper, this seems to be ugly:

'/' . Apache::TestRequest::module2path($module);

or at least the name is misleading (I know I gave it that name). So should we probably rename it to be module2segment or something like that, which doesn't suggest that it returns a valid path?

Alternatively fix it to append / internally, though it'll make othe
concatenations uglier:

my $location "http://$hostport$path";;

instead of:

my $location "http://$hostport/$path";;

or does the former look good?

given all the permutations, maybe we need an Apache::URI-like module that accounts for Win32 paths as well.


my $uri = Apache::TestRequest->parse($module);
$uri->query('env');
$uri->unparse.

if Apache::TestRequest::hostport() returns true, then the unparsed value is an absolute URI, otherwise it's relative.

--Geoff


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to