Stas Bekman wrote:
Randy Kobes wrote:

On Thu, 25 Sep 2003, Stas Bekman wrote:


Strange, Randy says, the patch won't apply. The patch had no tabs, may be the
mailer has messed it up. Here it is as an attachment.



That worked - thanks! And a quick run through has all the filter tests passing (using a sequence that failed before). However, some of the apr/pool tests fail for me:


So it doesn't prove anything yet, as it's not clear whether sub-pools were destroyed. Since the cleanup callbacks didn't run. Can you please try with this handler and post the debug prints from the error log as well. Thanks.

If that short test fails, please also try again after commenting out the two subtests calling ancestry_count().


sub handler {
    my $r = shift;

    plan $r, tests => 7;
    # test: destroying a sub-pool before the parent pool
    {
        my $pp = APR::Pool->new;

ok t_cmp(1, $pp->isa('APR::Pool'), "isa('APR::Pool')");

        ok t_cmp(1, ancestry_count($pp),
                 "a new pool has one ancestor: the global pool");

        ok t_cmp(2, ancestry_count($sp),
                 "a subpool has 2 ancestors: the parent and global pools");

And also please add debug printout into the cleanup callbacks:


sub add_cleanup {
    my $arg = shift;
    debug "adding cleanup note";
    $arg->[0]->notes->add(cleanup => $arg->[1]);
    1;
}

sub set_cleanup {
    my $arg = shift;
    debug "setting cleanup note";
    $arg->[0]->notes->set(cleanup => $arg->[1]);
    1;
}

so that when running the server with -trace=debug these will print out when they are called.

Thanks.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to