Man, you should at least give us a chance to test patches if you post them for review and not rushing to commit them. mp2 now can't be even built. Your patch has several problems. First of all the prototype is wrong, it should be:

apr_port_t modperl_default_port_handler(const request_rec *r)

since the declaration is:

include/http_protocol.h:AP_DECLARE_HOOK(apr_port_t,default_port,(const request_rec *r))

without the const, the build warns and dies. But once you put the const in we have another warning, since

(apr_port_t)modperl_callback_per_srv(MP_DEFAULT_PORT_HANDLER, rr, MP_HOOK_RUN_FIRST);

discards 'const'. which is not trivial to fix, so I stopped there, removed your change and finished building the project.

I don't understand how did it built for you. You aren't running in the maintainer mode, which turns all the compilation warnings into errors?

Besides, while looking why this thing is broken, I saw that this is an HTTP hook and has little to do with protocols, since its defined in include/http_protocol.h. So it definitely doesn't belong to the protocols documentation, but should be put together with other HTTP hooks. Also I still fail to see its usability. Both http and ssl already specify the default ports 80 and 443, what other default ports do we have in the HTTP protocol?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to