Man, you should at least give us a chance to test patches if you post them for review and not rushing to commit them. mp2 now can't be even built. Your patch has several problems. First of all the prototype is wrong, it should be:
apr_port_t modperl_default_port_handler(const request_rec *r)
since the declaration is:
include/http_protocol.h:AP_DECLARE_HOOK(apr_port_t,default_port,(const request_rec *r))
without the const, the build warns and dies. But once you put the const in we have another warning, since
(apr_port_t)modperl_callback_per_srv(MP_DEFAULT_PORT_HANDLER, rr, MP_HOOK_RUN_FIRST);
discards 'const'. which is not trivial to fix, so I stopped there, removed your change and finished building the project.
So any suggestions to how to fix that?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
