test suites are good for excercising functionality and some error conditions, but not always for reproducing real-world issues like that, unfortunately.
Frankly I don't think this applies to the undef-warn-on-exit problem, it's reproducable in a trivial cgi script. It must be something else in the test suite that masks the problem. I might take another look at it later on. As we mess with callback return statuses, it'd be nice to have it covered in the test suite.
indeed. can you post the script? I'll take a look at it too and see if I can figure out a way to reproduce it as well.
package CGItest;
use strict; use warnings;
use ModPerl::Util;
use Apache::RequestRec; use Apache::RequestIO;
sub handler
{
my $r = shift;
$r->content_type( "text/plain" );
print "hey geoff\n";
ModPerl::Util::exit;
}
1;If you really insist. I'm +1 on fixing the bug introduced by exit() fix and keeping the rest as before the s/POPi/POPs/ change (quietly coercing defined SVs to IV with any additional checks).
"rest as before" in what sense? do you mean keeping this part?
/* assume OK for non-http status codes and for 200 (HTTP_OK) */ if (((status > 0) && (status < 100)) || (status == 200) || (status > 600)) { status = OK;
I thought you had agreed earlier to be rid of this as well?
no, I was talking about the change I did to fix the undef-on-exit problem (i.e. replacing POPi with POPs)
at any rate, to avoid confusion, how about we address the issues separately. I'll commit some version of status.t/status.pm tomottow that matches the current behavior and illustrates the pv/iv bug. then we can review a fix for the bug and adjust the tests based on the model behavior we want for modperl_callback.
+1
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
