Re: current_callback return behavior

[Geoffrey Young]

What I meant is this:

        if (count != 1) {
            status = OK;
        }
        else {
            SV* status_sv = POPs;
            if (status_sv == &PL_sv_undef) {
                /* ModPerl::Util::exit returns undef */
                status = OK;
            }
            else {
                status = (IV)SvIV(status_sv);
I don't think you don't need that cast.

            }
            /* assume OK for 200 (HTTP_OK) */
            if ((status == 200)) {
                status = OK;
            }
        }
ok, so the difference between the approaches is that mine is explicit, 
giving us some useful debug messages for coerced strings in case we have 
future problems.

I just tested that the undef problem disappears (I can easily reproduce 
it) and the rest works just as before.
well, better than before, since the pv/iv issue is removed :)

it doesn't matter to me whether we do it your way or my way, so long as the 
string issue is fixed.  I happen to prefer more explicit debug messages myself.

I'll try again at getting a test reproduce this problem.
should be just a matter of setting PerlSwitches -w in the test suite (though 
who knows what that will start doing :)

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]