also we should probably add IPC::Run3 to lib/Bundle/Apache2.pm.
OK ... I also seem to remember that it would be better, within Apache::TestSmoke, to do a eval {require IPC::Run3; ....} and die if not there, rather than use IPC::Run3; Should I do that?
You are right, I remember the build failing when I added your patch and I didn't have IPC::Run3 installed. This was happening because other modules require TestSmoke. So it's not enough to just replace require with eval { require}, we need to move it away from the compilation phase. The best solution I believe would be to just have:
require IPC::Run3;
inside 'sub run_test'. Letting require() fail when t/SMOKE is run is OK.
one remaining problem is that the move to IPC::Run3 introduced: Ctrl-C is no longer trappable (due to its use of 'system') immediately which causes t/SMOKE think that the test has failed, when it didn't. I'll need to look at how to solve this.
If that's a big problem that you'd rather not wait to be solved, we could write things such that it'd do the pipe stuff on Unix and use IPC::Run3 on Win32 (or perhaps Win32::Process - I think Ctrl-C is trappable with it). This would mean more branches in the code, though ...
No, no, it's not a showstopper. I just mentioned this as something to look at. Hopefully we will find a nice solution while keeping IPC::Run3 for all.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
