On Thu, 9 Oct 2003, Stas Bekman wrote:
> works fine on linux, +1 to commit sans 'print $log', and
> probably it'd be a good idea to add a comment to why:
>
> Win32::Process::Create($obj,
> $httpd,
> "$cmd $one_process",
> - 0,
> + 1,
OK, I'll do that.
> also we should probably add IPC::Run3 to lib/Bundle/Apache2.pm.
OK ... I also seem to remember that it would be better,
within Apache::TestSmoke, to do a
eval {require IPC::Run3; ....}
and die if not there, rather than
use IPC::Run3;
Should I do that?
> one remaining problem is that the move to IPC::Run3
> introduced: Ctrl-C is no longer trappable (due to its use
> of 'system') immediately which causes t/SMOKE think that
> the test has failed, when it didn't. I'll need to look at
> how to solve this.
If that's a big problem that you'd rather not wait to be
solved, we could write things such that it'd do the pipe
stuff on Unix and use IPC::Run3 on Win32 (or perhaps
Win32::Process - I think Ctrl-C is trappable with it).
This would mean more branches in the code, though ...
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
