> Besides comments below, I think we shouldn't support: > > Apache->server_root_relative and equivalents, but only: > > ($r|$s|$c)->server_root_relative(...) and > Apache::server_root_relative($pool, ...) > > because users will get bad memory leaks when a global pool is used to > allocate memory in requests. We should support the non-(pool|$r|$c|$s) > argument functions only in compat and may be even print a warning when > used for the first time. > > What do you think?
sounds fine to me. the functional no-args for was bothersome to me anyway, and this makes coding it easier. > I don't think the non-Server functions belong here. They should go into > respective xs/Apache/ files. I did try that, but I couldn't seem to get to mpxs_ap_server_root_relative from the other .h files. but then I thought it was ok - there are lots of examples where .h files are used to define methods for other classes, especially the util classes. for instance Apache::server_root_relative lives in Apache__ServerUtil.h, Apache::RequestRec::as_string lives in Apache__RequestUtil.h, etc. so there's precedent. is it ok this way? > Can't #define be used here, they are all > the same? #define would probably be better. I'll do that instead. thanks :) --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
