> Beautiful work, Geoff. thanks. it was much more involved than it appeared to be from looking at the release file :)
> > The only comment I have is we should probably use DEFINEs for xs > wrappers, since your functions don't do anything but pass the args > through as is. agreed. > So if it's not used anywhere else may be it should become static then > and removed from modperl_util.h? agreed. > >> it no longer returns a global pool at all > > I think it's a goodness not to use the global pool for any public APIs > that could be used at request run-time. Makes it a tiny bit harder on > users, but at the same time it makes harder for them to shoot themselves > into their foot. agreed > >> and now supports properly formatted subclasses. > > goodness! :) all is now checked in with the above suggestions incorporated. thanks for the feedback. --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
