On Thu, 2004-02-05 at 17:38 -0500, Geoffrey Young wrote: > Philippe M. Chiasson wrote: > > Caught a few little problems caught by gcc -Wall -Werror this morning. > > [...] > hmm, I'm not seeing any of these with -Wall and -Werror. > [...] > my current setup uses MP_MAINTAINER=1 only, which is supposed to enable both > of those flags. > > do you have a compiler flag that I'm missing? I'm on gcc version 3.2.2, so > maybe you have access to something I don't.
gcc version 3.3.2 20040119 with -Wall -Werror tells me : modperl_filter.c: In function `modperl_filter_resolve_init_handler': modperl_filter.c:329: warning: `package_name' might be used uninitialized in this function modperl_filter.c:330: warning: `cv' might be used uninitialized in this function modperl_const.c: In function `new_constsub': modperl_const.c:13: warning: `val' might be used uninitialized in this function apr_perlio.c: In function `PerlIOAPR_open': apr_perlio.c:61: warning: `apr_flag' might be used uninitialized in this function And in the case of apr_perlio, in both instanced I arbitrairly picked a default for the mode, but instead, it could have a default: clause to the case and warn/bail... > --Geoff -- -------------------------------------------------------------------------------- Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B) http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5 Q: It is impossible to make anything foolproof because fools are so ingenious. perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
signature.asc
Description: This is a digitally signed message part
