On Tue, 2004-02-10 at 19:10 -0800, Stas Bekman wrote:
Philippe M. Chiasson wrote:
Caught a few little problems caught by gcc -Wall -Werror this morning.
Good catches, philippe. But plugging these holes with "random" values is ain't right. There is a logic bug that needs to be fixed if we have these issues.
Yes, I agree with you. I plugged those holes with pretty bad assumptions. I took in your suggestions, and tested it against my gcc with success.
Only adding a case default that Perl_croaks works fine too.
Cool. So it's smart enough to figure out that it asserts.
BTW, gcc 3.4 is out.
With the following patch, compiles cleans & all tests pass!
Looks good, with a tiny remark below:
Index: src/modules/perl/modperl_filter.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.81
diff -u -I$Id -r1.81 modperl_filter.c
--- src/modules/perl/modperl_filter.c 9 Feb 2004 19:32:42 -0000 1.81
+++ src/modules/perl/modperl_filter.c 11 Feb 2004 21:45:37 -0000
@@ -325,30 +325,28 @@
int modperl_filter_resolve_init_handler(pTHX_ modperl_handler_t *handler,
apr_pool_t *p)
{
- char *init_handler_pv_code;
- char *package_name;
- CV *cv;
- MAGIC *mg;
+ char *init_handler_pv_code = NULL;
why do you need to init char *?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
