Geoffrey Young wrote:
for sure output filters are getting PerlResponseHandler, which is
clearly a bug, but not one that is easily fixed.


it depends on how do you look at it. I think it's a goodness to know
inside a filter what phase is it running in. So I don't mind making
filters different than any other phases. Request filters are always
running inside the response phase, and connection filters can be called
from any pre-log phase.


I guess I was looking for a handler configured with PerlOutputFilterHandler
to return 'PerlOuputFilterHandler' for $r->current_callback, not
'PerlResponseHandler' which is clearly a different thing.

but yes, I see your point that it's the response phase nonetheless.  so,
maybe either $r->current_callback is misnamed, or we should be returning,
say, 'response' and 'translation' instead of 'PerlResponseHandler' and
'PerlTransHandler'?

just an idea.

OK, may be $r->current_phase is more intuitive? which makes filters different, since they aren't a phase. I'm not sure about the return values: 'response' is good, but 'translation' is confusing to someone who is used to 'Trans' in perl or 'trans' in C. Unless we want to come up with our own mapping of C names to the long names.


and in addition may be $r->current_handler, to return the current handler name? 'PerlOuputFilterHandler', 'PerlResponseHandler', etc.?


__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to