On Mon, 2004-02-09 at 18:18 +0000, [EMAIL PROTECTED] wrote: > stas 2004/02/09 10:18:16 > > Modified: lib/ModPerl Code.pm > src/modules/perl modperl_cmd.c modperl_cmd.h > t/filter/TestFilter in_bbs_inject_header.pm in_bbs_msg.pm > in_str_msg.pm > todo release > . Changes > Log: > Perl(Input|Output)FilterHandler handlers are now always AutoLoaded, as > if '+' prefix was used. This must be performed to get the access to > filter attributes long before the filter itself is executed. > + tests > > [...] > > Index: in_bbs_inject_header.pm > =================================================================== > RCS file: /home/cvs/modperl-2.0/t/filter/TestFilter/in_bbs_inject_header.pm,v > retrieving revision 1.2 > retrieving revision 1.3 > diff -u -u -r1.2 -r1.3 > --- in_bbs_inject_header.pm 7 Oct 2003 01:04:13 -0000 1.2 > +++ in_bbs_inject_header.pm 9 Feb 2004 18:18:16 -0000 1.3 > @@ -208,8 +208,6 @@ > __END__ > <NoAutoConfig> > <VirtualHost TestFilter::in_bbs_inject_header> > - # must be preloaded so the FilterConnectionHandler attributes will > - # be set by the time the filter is inserted into the filter chain > PerlModule TestFilter::in_bbs_inject_header > PerlInputFilterHandler TestFilter::in_bbs_inject_header > <Location /TestFilter__in_bbs_inject_header> >
Now that PerlinputFilterHandler automagically preloads the module, shouldn't the PerlModule line be removed from the tests for clarity/consistency ? > > 1.6 +0 -2 modperl-2.0/t/filter/TestFilter/in_bbs_msg.pm > > Index: in_bbs_msg.pm > =================================================================== > RCS file: /home/cvs/modperl-2.0/t/filter/TestFilter/in_bbs_msg.pm,v > retrieving revision 1.5 > retrieving revision 1.6 > diff -u -u -r1.5 -r1.6 > --- in_bbs_msg.pm 8 Jan 2004 23:36:56 -0000 1.5 > +++ in_bbs_msg.pm 9 Feb 2004 18:18:16 -0000 1.6 > @@ -80,8 +80,6 @@ > __END__ > <NoAutoConfig> > <VirtualHost TestFilter::in_bbs_msg> > - # must be preloaded so the FilterConnectionHandler attributes will > - # be set by the time the filter is inserted into the filter chain > PerlModule TestFilter::in_bbs_msg > PerlInputFilterHandler TestFilter::in_bbs_msg > > > > 1.5 +0 -2 modperl-2.0/t/filter/TestFilter/in_str_msg.pm > > Index: in_str_msg.pm > =================================================================== > RCS file: /home/cvs/modperl-2.0/t/filter/TestFilter/in_str_msg.pm,v > retrieving revision 1.4 > retrieving revision 1.5 > diff -u -u -r1.4 -r1.5 > --- in_str_msg.pm 18 Apr 2003 06:18:57 -0000 1.4 > +++ in_str_msg.pm 9 Feb 2004 18:18:16 -0000 1.5 > @@ -48,8 +48,6 @@ > 1; > __END__ > <VirtualHost TestFilter::in_str_msg> > - # must be preloaded so the FilterConnectionHandler attributes will > - # be set by the time the filter is inserted into the filter chain > PerlModule TestFilter::in_str_msg > PerlInputFilterHandler TestFilter::in_str_msg > > [...] -- -------------------------------------------------------------------------------- Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B) http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5 Q: It is impossible to make anything foolproof because fools are so ingenious. perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
signature.asc
Description: This is a digitally signed message part
