On Tue, 2004-02-10 at 03:28 -0500, Andres Salomon wrote: > Philippe M. Chiasson wrote: > [...] > > | > | Could someone running the ModPerl-Registry tests on Win32 or something > | similarly non-POSIX with this ACL patch ? > | > [...] > > Shouldn't this also touch the -r test a few lines earlier, as well? > Even better, why not put the "use filetest" at the beginning of the > function, as it seems that it should affect all file permission tests.
Yes, I missed that indeed. This simpler patches most likely does the
trick.
Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm,v
retrieving revision 1.41
diff -u -I$Id -r1.41 RegistryCooker.pm
--- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm 25 Jan 2004 01:04:16 -0000
1.41
+++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm 10 Feb 2004 21:10:49 -0000
@@ -224,6 +224,9 @@
my $self = shift;
my $r = $self->{REQ};
+ #Allow correct detection even under ACLs-enable filesystems (i.e. ext3)
+ use filetest qw(access);
+
unless (-r $r->my_finfo && -s _) {
$self->log_error("$self->{FILENAME} not found or unable to stat");
return Apache::NOT_FOUND;
Can you try this and confirm that it works the way it should for your
setup ?
--
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
signature.asc
Description: This is a digitally signed message part
