Philippe M. Chiasson wrote:
On Wed, 2004-02-11 at 15:15 -0500, Andres Salomon wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philippe M. Chiasson wrote:
[...]
|
| Can you try this and confirm that it works the way it should for your
| setup ?
|

It looks like there's still an issue with the way filetest is being
used.  As Damon Buckwalters pointed out to me, filetest::access requires
the filename; a filehandle won't work.  I've attached his patch, which
looks correct.



Problem with that approach is that it will add the cost of 2 stat calls
for each and every single ModPerl::Registry scripts ;-(

I think it might be worth considering a new ModPerl::RegistryCooker
subclass just for ACL support. Since most people don't use ACLs, it
seems unjustified to me to incur the overhead to everybody.

Seconded.


People with need for ACL support could just be made to use ModPerl::
RegistryACL, for example ...

I'm also thinking that all these new M-RC subclasses should probably go to CPAN. I don't think we should supply a bunch of subclasses in the core. Only if some subclasses get very popular we should consider including them in the core later on.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to