Geoffrey Young wrote: [...]
Now, given that the select code is run anyway inside the callback, just take the select/unselect parts out of if (MpDirSETUP_ENV(dcfg)), similar to perl-script.
I don't see where parts are removed for perl-script versus what I had. but I think I see how the MpInterpPUTBACK stuff can be removed in the modperl handler, since you only need context for the call to modperl_env_request_populate and the callback does another full select/rcfg->interp population later. is that what you meant?
The callback doesn't do a full select AFAIR, if you already did a select. But your patch below is fine. I was just suggesting to have if (MpDirSETUP_ENV(dcfg)) only around modperl_env_request_populate.
So +1, next it'd be nice to refactor that select/unselect into macros, which will make the code more readable.
With the fix above, yes. I haven't read through the rest of the patch, assuming that it's the same as the previous one.
it was different in that it incorporated your other comments (which is why I posted the whole thing :)
ah, of course, I've scanned the parts I've commented on and it looks good.
nice work, Geoff!
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
