Finally got around implementing Apache::PerlSections->(dump|store);
Comments ?
Index: lib/Apache/PerlSections.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/PerlSections.pm,v
retrieving revision 1.2
diff -u -I$Id -r1.2 PerlSections.pm
--- lib/Apache/PerlSections.pm 19 Dec 2003 01:17:31 -0000 1.2
+++ lib/Apache/PerlSections.pm 28 Feb 2004 02:38:56 -0000
@@ -24,6 +24,10 @@
sub directives { return shift->{'directives'} ||= [] }
sub package { return shift->{'args'}->{'package'} }
+our @saved;
why do you need a global here? won't my() work?
Index: lib/Apache/PerlSections/Dump.pm =================================================================== RCS file: lib/Apache/PerlSections/Dump.pm diff -N lib/Apache/PerlSections/Dump.pm --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ lib/Apache/PerlSections/Dump.pm 28 Feb 2004 02:38:56 -0000 @@ -0,0 +1,79 @@ +package Apache::PerlSections::Dump; + +use strict; +use warnings FATAL => 'all'; + +our $VERSION = '0.01'; + +use Apache::PerlSections; +our @ISA = qw(Apache::PerlSections);
i think 'use base' is pretty safe to use with 5.6.1+
+use Data::Dumper;
+
+sub package { return shift->saved }
+sub save { return }
+sub post_config { return }
What's the point of 'return'? Don't you want to have something like:
sub save {
warn "this (save) is a virtual method: you need to implement it";
return
}or similar? may be using caller to get the class name... same for the other virtual method... write a wrapper?
the rest looks good, Philippe!
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
