Geoffrey Young wrote:
hi all

can somebody on win32 verify this patch for me?  IIRC the required fix was
committed in november, and 2.0.49 is the latest release that contains the
fix, so all should be ok now.

thanks

--Geoff


------------------------------------------------------------------------


Index: t/response/TestAPR/finfo.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPR/finfo.pm,v
retrieving revision 1.8
diff -u -r1.8 finfo.pm
--- t/response/TestAPR/finfo.pm 14 Jan 2004 21:27:41 -0000 1.8
+++ t/response/TestAPR/finfo.pm 8 Apr 2004 16:30:50 -0000
@@ -9,6 +9,8 @@
use Apache::TestConfig;
use constant WIN32 => Apache::TestConfig::WIN32;
+use constant APACHE_2_0_49 => have_apache_version('2.0.49');

I think we need a separate API for this kind of things. The problem with using
have_apache_version is that if you don't have it, it'll push the reason into @skip list and if the test gets skipped it'll print that reason, even though you didn't mean it to. So it happens to work as long as we don't skip the test, but otherwise could produce confusing output. I know we are using it in a few other places as well.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to