+use constant APACHE_2_0_49 => have_apache_version('2.0.49');
I think we need a separate API for this kind of things. The problem with using have_apache_version is that if you don't have it, it'll push the reason into @skip list and if the test gets skipped it'll print that reason, even though you didn't mean it to. So it happens to work as long as we don't skip the test, but otherwise could produce confusing output. I know we are using it in a few other places as well.
well we need to make the call at some point - that's what the Apache::Test APIs are there for and I wouldn't want to write or support another set just because of the @SkipReason foo.
It's not "just because of the @SkipReason foo". That API was written explicitly for plan()/skip() API and was not designed for other uses. It didn't happen the other way around (i.e. SkipReason wasn't added later).
do you have some suggestions?
At the moment the only idea I have is to have 2 different sets of APIs which underneath will call the same core functions. e.g.:
skip_have_... have_...
the only difference is that skip will also push the reason, and non-skip won't. But may be there are better ideas.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
