On Wed, 14 Jul 2004, Stas Bekman wrote:
> Markus Wichitill wrote:
> >>Adding MP_AP_PREFIX/bin
> >>to your PATH is the simplest approach to this (I'll have
> >>to see about doing this automatically for the tests).
> >
> > How about this?
>
> I'm not sure what is it for, too much context removed, but
> I guess Randy knows what is it about.
It comes about because, when running the tests, Apache
may need certain external dlls in the Apache bin/ directory.
The PATH is used to search for these dlls.
> I have only one
> comment regard to code below
>
> > Index: Makefile.PL
> > ===================================================================
> > RCS file: /home/cvspublic/modperl-2.0/Makefile.PL,v
> > retrieving revision 1.143
> > diff -u -r1.143 Makefile.PL
> > --- Makefile.PL 5 Jul 2004 22:02:42 -0000 1.143
> > +++ Makefile.PL 14 Jul 2004 21:55:20 -0000
> > @@ -597,9 +597,14 @@
> >
> > sub MY::test {
> >
> > + my $apr_bindir = $build->apr_bindir();
>
> it's not guaranteed that $build->apr_bindir() will return a defined
> value, so it's better to:
>
> my $apr_bindir = $build->apr_bindir() || '';
>
> if you later use it in the string:
>
> > - my $preamble = Apache::TestConfig::WIN32 ? "" : <<EOF;
> > + my $preamble = Apache::TestConfig::WIN32
> > + ? <<EOF
> > +PATH = \$(PATH);$apr_bindir
> > +EOF
> > + : <<EOF;
> > PASSENV = $env
> > EOF
What about the following?
======================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.143
diff -u -r1.143 Makefile.PL
--- Makefile.PL 5 Jul 2004 22:02:42 -0000 1.143
+++ Makefile.PL 15 Jul 2004 01:22:50 -0000
@@ -598,8 +598,13 @@
sub MY::test {
my $env = Apache::TestConfig->passenv_makestr();
+ my $ap_bindir = File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin');
- my $preamble = Apache::TestConfig::WIN32 ? "" : <<EOF;
+ my $preamble = Apache::TestConfig::WIN32
+ ? <<EOF
+PATH = \$(PATH);$ap_bindir
+EOF
+ : <<EOF;
PASSENV = $env
EOF
===============================================================
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
