Randy Kobes wrote:
No, I wasn't thinking of that possibility; I just thought MP_AP_PREFIX would be simpler, but I forgot about using MP_APXS instead. What about the following - it tries both, and if neither are defined, it give up. =============================================================== Index: Makefile.PL =================================================================== RCS file: /home/cvs/modperl-2.0/Makefile.PL,v retrieving revision 1.143 diff -u -r1.143 Makefile.PL --- Makefile.PL 5 Jul 2004 22:02:42 -0000 1.143 +++ Makefile.PL 15 Jul 2004 03:56:21 -0000 @@ -598,8 +598,17 @@ sub MY::test {
my $env = Apache::TestConfig->passenv_makestr(); + my $ap_bindir = $build->apr_bindir(); + if (! $ap_bindir) { + $ap_bindir = $build->{MP_AP_PREFIX} ? + File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin') : ''; + }
Add ap_bindir to the Build package?
- my $preamble = Apache::TestConfig::WIN32 ? "" : <<EOF; + my $preamble = Apache::TestConfig::WIN32 + ? <<EOF +PATH = \$(PATH);$ap_bindir +EOF + : <<EOF; PASSENV = $env EOF
As mentioned in my previous followup, the two preambles have nothing to do with each other: one doesn't use $env, the other doesn't use bindir. How about making a clear separation as I suggested in the rewritten code?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
