While it was relatively fresh in my mind (I'm going to a workshop next week), I converted a set of the apr tests to use a common base under t/lib/TestAPRlib/ for both the t/apr/ and t/apr-ext/ tests. This is at http://www.apache.org/~randyk/t_apr.tar.gz, which unpacks into a series of individual diffs for each test.
Excellent job, Randy :)
These are +1 ------------ base64.diff bucket.diff date.diff finfo.diff string.diff threadmutex.diff uri.diff util.diff ---------
pool.diff --------- ancestry_count doesn't have to be duplicated, no? Just call it with TestAPRlib::pool::ancestry_count?
uuid.diff --------- I guess we can now drop this part:
have {"the build couldn't find apr-config" => $has_apr_config};and the code above it that sets $has_apr_config
assuming that we have apr-ext working everywhere. if not then it must
appear in all apr-ext tests. Based on the user reports so far that's probably the case (sometimes we fails to find apr-config). We don't want users to be afraid to install mod_perl because of apr-ext failures.
So I'd suggest that we write a wrapper that does that check, then replace all use() APR:: and TestAPRlib:: with require and move 'require APR::*' into the test() itself.
But to start with I think you can go ahead and commit everything, so that we can continue working on the tests and not step on each other toes.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
