Stas Bekman wrote: [...]
I guess we can now drop this part:
have {"the build couldn't find apr-config" => $has_apr_config};
and the code above it that sets $has_apr_config
assuming that we have apr-ext working everywhere. if not then it must
appear in all apr-ext tests. Based on the user reports so far that's probably the case (sometimes we fails to find apr-config). We don't want users to be afraid to install mod_perl because of apr-ext failures.
So I'd suggest that we write a wrapper that does that check, then replace all use() APR:: and TestAPRlib:: with require and move 'require APR::*' into the test() itself.
For example write a wrapper around plan() so instead of calling plan, we will call TestAPRlib::common::plan which will have the same arguments as plan(), but will first run the $has_apr_config checks and handle the skip if necessary. All require APR::* should come after calling TestAPRlib::common::plan.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
