Philippe M. Chiasson wrote:
When looking for apr-config/apu-config in httpd's source tree, look
both in srclib/apr and srclib/apr-util

+1 on the concept, but it'd be nice to rewrite this section. That $_ is not the most beautiful part of it. I think using


 for my $base (grep defined $_, $self->dir)
    ...
    push @tries

or something like that will make the code more readable

------------------------------------------------------------------------

When looking for apr-config/apu-config in httpd's source tree, look
both in srclib/apr and srclib/apr-util

Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.179
diff -u -I$Id -r1.179 Build.pm
--- lib/Apache/Build.pm 18 Sep 2004 23:27:39 -0000 1.179
+++ lib/Apache/Build.pm 20 Sep 2004 20:43:04 -0000
@@ -984,7 +984,11 @@
my @tries = ();
if ($self->httpd_is_source_tree) {
push @tries, grep { -d $_ }
- map catdir($_, "srclib", "apr"),
+ map {
+ my $base = $_; + map { catdir($base, "srclib", $_) } + qw(apr apr-util) + }
grep defined $_, $self->dir;
}
else {




------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to