Over irc we have decided to dump log_reason. But now that I've looked at it, I'm not sure whether we should do that. If you call:

  $r->log_reason("What's the reason?");

you get:

[Wed Sep 22 22:06:23 2004] [error] access to /My__Bug failed for 127.0.0.1, reason: What's the reason?

and there is no such equivalent API. in mp1 it was defined as:

#define mod_perl_log_reason(msg, file, r) \
    aplog_error(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO, r->server, \
                "access to %s failed for %s, reason: %s", \
                file, \
                get_remote_host(r->connection, \
                                r->per_dir_config, REMOTE_NAME), \
                msg)

I suppose we could just copy it over and then we don't need the compat.

What do you think?

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to