Randy Kobes wrote:
On Sat, 23 Apr 2005, Stas Bekman wrote:
Randy Kobes wrote:
[ .. ]
That'd be nice to clean this up ... I'm wondering
though about having, in particular, apr-ext tests for
socket.pm
sockaddr.pm
brigade.pm
that simply load the modules. In looking at the corrsponding
responses in t/response/TestAPR/, it appears in their
current form that all 3 of these require mod_perl to do
their work. Might having a corresponding apr-ext test lead
some to believe that these function outside of mod_perl, and
so in this context their presence could be considered
somewhat misleading?
That's correct for the socket modules, as there is no way
to get the apr socket at the moment but via mod_perl. but
what's wrong with brigade API? you can create one
yourself:
$bb = APR::Brigade->new($pool, APR::BucketAlloc->new($pool));
That's right - I don't know why I didn't recognize this
at the time we were refactoring the apr/apr-ext tests.
How about the following diff, which adds a brigade test
to apr-ext?
+1
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
