Torsten Foertsch wrote:
> On Friday 09 June 2006 15:04, Geoffrey Young wrote:
>
>>>The more I think of it the more I am convinced that this is not good. If
>>>you think $r->pnotes behaves the way it is designed to then let it be so.
>>>There is indeed an interface that already does what the new one is
>>>intended to do, that is $r->pnotes->{key}=value. Hence, no need for an
>>>additional interface.
>>
>>I'm upset that there is a difference in the two interfaces to pnotes() -
>>this just shouldn't be the case at all.
>>
>>care to add a TODO test to pnotes in the mp2 test suite? that pnotes()
>>behaves differently depending on how it's called _needs_ to be fixed imho.
>
>
> Now, I am a bit puzzled. For months you have convinced me that pnotes()
> behaves the way it is designed to.
it does... at least if you use the $r->pnotes(key => value) syntax. I
didn't realize there was a difference between this (preferred for eons)
syntax and the tied (essentially deprecated, never suggested on list)
syntax. that there is a difference constitutes a bug in and of itself.
> Now that I have given up you out of the
> sudden switch hats. Is my English so bad to be not understandable?
>
> Anyway, I'd like to provide these tests if we agree on what the "right"
> interface is. Should
>
> a) $r->pnotes(key=>value) behave like $r->pnotes->{key}=value or
>
> b) $r->pnotes->{key}=value behave like $r->pnotes(key=>value)
>
> I would vote for a). That means $r->pnotes(key=>value) is to be changed to
> behave like an ordinary Perl hash.
I think the solution for the moment is to keep thing the way they are in
1.3, then determine a suitable path for altering the behavior in some
2.X release cycle. however the masses think the pnotes referencing
thing should behave is fine with me, provided both forms behave
identically - there should be absolutely no difference whether you're
using the method or tied interface to any tied object.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
