Re: [mp2 patch] Support for Perl 5.10 [Was: MP_CODE_ATTRS() is broken under perl 5.10.0]

[Philippe M. Chiasson]

Randy Kobes wrote:

On Sat, 26 Jan 2008, Philippe M. Chiasson wrote:

Randy Kobes wrote:

On Thu, 24 Jan 2008, Philippe M. Chiasson wrote:

[ ... ]

Following is a patch (probably will change some more before I am done) that gets rid of this hacking attribute handling and passes it around with magic.

Great work! And thanks for the explanations :)

No problems, happy to hear it works.

This XS stuff is pretty hairy at times - it was really
insightful as you walked us through it ...

I write it down so I'll remember it next time I have to look
at that part ;-)

I've applied a modified version of this patch (attached)
to Win32 ActivePerl 5.10 (build 1002) with Apache/2.2.8;
there's some problems with the t/perl/ithreads*.t tests,
which I'll look at more carefully, but all the filter
tests now pass.

Nice, that's pretty good. If you can at least figure out
what's going on with these tests, that sure would help.

My Apache crashed on all the t/perl/ithreads*.t tests,
as well as in the ithreads test in ModPerl-Registry (after

looking for Win32-specific things - does anyone have
experience with a threaded perl-5.10 on these tests?

removing the Apache2-Reload stuff), but all the others passed. I'll start a new message about this when I gather some new information, but I was wondering if I should be

Just built myself a threaded perl-5.10 and I see them too:

Failed Test               Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/directive/perlrequire.t                2    1  1
t/perl/ithreads.t                        4    3  2-4
t/perl/ithreads2.t         255 65280    ??   ??  ??
t/perl/ithreads_args.t                  ??   ??  ??
t/perl/ithreads_eval.t                  ??   ??  ??
32 tests and 5 subtests skipped.
Failed 5/244 test scripts. 6/2374 subtests failed.
Files=244, Tests=2374, 222 wallclock secs (123.58 cusr + 15.14 csys = 138.72 
CPU)
Failed 5/244 test programs. 6/2374 subtests failed.

Getting these to pass will be next on my list.

--
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/

signature.asc
Description: OpenPGP digital signature