Randy Kobes wrote:
On Thu, 24 Jan 2008, Philippe M. Chiasson wrote:[ ... ]Following is a patch (probably will change some more before I am done) that gets rid of this hacking attribute handling and passes it around with magic.Great work! And thanks for the explanations :) I've applied a modified version of this patch (attached) to Win32 ActivePerl 5.10 (build 1002) with Apache/2.2.8; there's some problems with the t/perl/ithreads*.t tests, which I'll look at more carefully, but all the filter tests now pass. The changes I made to your original patch are: - change the name of mp_code_attrs to modperl_code_attrs, as the modperl_ prefix is used for the other functions that go into mod_perl.so - add modperl_code_attrs to ModPerl::FunctionTable, so that it's added to modperl.def (Win32 needs this to include the functions in mod_perl.so)- add a (CV*) cast in MP_CODE_ATTRS in src/modules/perl/mod_perl.h, to avoid a warningwhen compiling Apache2::Filter
I've included these changes and a few more cleanups as revision 615751. -- Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature
