[ 
https://issues.apache.org/jira/browse/PHOENIX-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049139#comment-14049139
 ] 

James Taylor commented on PHOENIX-1015:
---------------------------------------

Thanks for the excellent work, [~rajesh23].

How is ReferencingColumn different than ColumnReference? Would it be possible 
to add what's missing to ColumnReference?

Also, would you mind clarifying a bit in a comment when the WHERE clause would 
be null and a local index would be used (in QueryOptimizer)?

{code}
===================================================================
--- 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/util/IndexManagementUtil.java
     (revision 786)
+++ 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/util/IndexManagementUtil.java
     (working copy)
@@ -119,11 +119,11 @@
         };
     }
 
-    private static class ReferencingColumn {
+    public static class ReferencingColumn {
         ImmutableBytesPtr family;
         ImmutableBytesPtr qual;
 
-        static ReferencingColumn wrap(ColumnReference ref) {
+        public static ReferencingColumn wrap(ColumnReference ref) {
             ImmutableBytesPtr family = new ImmutableBytesPtr(ref.getFamily());
             ImmutableBytesPtr qual = new ImmutableBytesPtr(ref.getQualifier());
             return new ReferencingColumn(family, qual);
{code}


> Support joining back to data table row from local index when query condition 
> involves leading columns in local index
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1015
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1015
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: PHOENIX-1015.patch, PHOENIX-1015_v6.patch, 
> PHOENIX-1015_v7.patch, PHOENIX-1015_v8.patch, PHOENIX-1015_v8.rar
>
>
> When a query involves more columns to project than columns in index and query 
> condition involves leading columns in local index then first we can get 
> matching rowkeys from local index table and then get the required columns 
> from data table. In local index both data region and index region co-reside 
> in the same RS, we can call get on data region to get the missing columns in 
> the index, without any n/w overhead. So it's efficient. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to