Ok, after talking to James offline we've come to following solution:
 - updating tracing docs to include the properties in the aforementioned
files
 - next release will include the config files explicitly

+1 on this RC

-------------------
Jesse Yates
@jesse_yates
jyates.github.com


On Fri, Aug 22, 2014 at 2:16 PM, Jesse Yates <[email protected]>
wrote:

> Ah, then the phoenix-4.1.0-bin tarball doesn't include the tracing configs
> for hadoop2. I'm actually not entirely clear on how that tarball is
> actually created... it doesn't seem to be explicity specified in
> phoenix-assembly or top-level phoenix pom (but I'm probably just blind).
>
> -------------------
> Jesse Yates
> @jesse_yates
> jyates.github.com
>
>
> On Fri, Aug 22, 2014 at 1:57 PM, James Taylor <[email protected]>
> wrote:
>
>> We build separate hadoop1/hadoop2 jars and include them both in the
>> distro,
>> I believe.
>>
>> James
>>
>> On Friday, August 22, 2014, Jesse Yates <[email protected]> wrote:
>>
>> > Maybe -1...
>> >
>> > We don't have a binary artifact for hadoop2, which is necessary to use
>> > tracing. I think this was an oversight in the tracing work to not
>> > differentiate the two tarballs (which are actually different beyond just
>> > the jars as hadoop2 includes custom config files as well) since this is
>> the
>> > first release we actually have anything in the hadoop2/hadoop-compat
>> > modules.
>> >
>> > -------------------
>> > Jesse Yates
>> > @jesse_yates
>> > jyates.github.com
>> >
>> >
>> > On Fri, Aug 22, 2014 at 12:37 PM, Eli Levine <[email protected]
>> > <javascript:;>> wrote:
>> >
>> > > +1 Looks good to me
>> > >
>> > >
>> > > On Thu, Aug 21, 2014 at 5:08 PM, Mujtaba Chohan <[email protected]
>> > <javascript:;>>
>> > > wrote:
>> > >
>> > > > +1
>> > > >
>> > > > Verified performance is on par with 4.0.0-incubating release.
>> > > >
>> > > > //mujtaba
>> > > >
>> > > >
>> > > > On Thu, Aug 21, 2014 at 4:14 PM, James Taylor <
>> [email protected]
>> > <javascript:;>>
>> > > > wrote:
>> > > >
>> > > > > Hi everyone,
>> > > > > This is a call for a vote on Apache Phoenix 4.1.0 RC0. This is the
>> > > > > next minor release of Phoenix compatible with the 0.98 branch of
>> > > > > Apache HBase and will be our second release as a top level
>> project.
>> > The
>> > > > > release includes both a source-only release and a convenience
>> binary
>> > > > > release.
>> > > > >
>> > > > > In addition to having all the bug fixes and the new features
>> outlined
>> > > > > for our 3.1 release currently being voted on (
>> http://s.apache.org/0N
>> > ),
>> > > > > it has several additional features:
>> > > > > - Support for local indexing which targets write heavy, space
>> > > > > constrained use cases by colocating index and table data on the
>> same
>> > > > > region server (
>> > > > > http://phoenix.apache.org/secondary_indexing.html#Local_Indexing
>> ).
>> > > > > - Support for tracing which leverages Cloudera’s HTrace library to
>> > > > > show per-request performance metrics all they way from the client
>> > > > > through into the HBase server, and back again
>> > > > > (http://phoenix.apache.org/tracing.html).
>> > > > >
>> > > > > For a complete list of changes, see:
>> > > > > https://raw.githubusercontent.com/apache/phoenix/4.0/CHANGES
>> > > > >
>> > > > > The source tarball, including signatures, digests, etc can be
>> found
>> > at:
>> > > > >
>> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.1.0-rc0/src/
>> > > > >
>> > > > > The binary artifacts can be found at:
>> > > > >
>> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.1.0-rc0/bin/
>> > > > >
>> > > > > Release artifacts are signed with the following key:
>> > > > > https://people.apache.org/keys/committer/mujtaba.asc
>> > > > >
>> > > > > KEYS file available here:
>> > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS
>> > > > >
>> > > > > The hash and tag to be voted upon:
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=98b02975f015159e9589094ff808bd26f8271bfd
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.1.0-rc0
>> > > > >
>> > > > > Vote will be open for at least 72 hours. Please vote:
>> > > > >
>> > > > > [ ] +1 approve
>> > > > > [ ] +0 no opinion
>> > > > > [ ] -1 disapprove (and reason why)
>> > > > >
>> > > > > Thanks,
>> > > > > The Apache Phoenix Team
>> > > > >
>> > > >
>> > >
>> >
>>
>
>

Reply via email to