[
https://issues.apache.org/jira/browse/PHOENIX-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122239#comment-14122239
]
James Taylor commented on PHOENIX-1241:
---------------------------------------
My proposal:
- If the annotations are our Phoenix annotations, we should know the type in
advance and declare it in the Phoenix tracing table. In that case, we shouldn't
need to do any type coercion.
- If the annotations aren't ours (i.e. it's not a Phoenix annotation, but an
HBase annotation), then we find out the "destination type" by looking up the
column in the Phoenix tracing table using the annotation key as a simple
mapping mechanism. The type of the column determines its destination type. If
the column isn't found, we fallback to string.
I don't think we should do too much magic converting the annotation key (i.e.
splitting on "."), but it is inconvenient that we'd have "." characters in the
column names. It's manageable (by wrapping column references in double quotes),
just a bit ugly. If there's a very clear conversion, I suppose it's ok to try,
but then you might have collisions between HBase ones and Phoenix ones. We
could separate into separate column families potentially, but first pass maywe
just keep it simple.
> Add typing to trace annotations
> -------------------------------
>
> Key: PHOENIX-1241
> URL: https://issues.apache.org/jira/browse/PHOENIX-1241
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0, 4.1.1
> Reporter: Jesse Yates
> Fix For: 5.0.0, 4.1.1
>
>
> Currently traces only support storing string valued annotations - this works
> for known trace sources. However, phoenix will have trace annotations with
> specific types. We can improve the storage format to know about these custom
> types, rather than just storing strings, making the query interface more
> powerful.
> See PHOENIX-1226 for more discussion
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
