[
https://issues.apache.org/jira/browse/PHOENIX-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123848#comment-14123848
]
Jesse Yates commented on PHOENIX-1241:
--------------------------------------
For the second point, are you proposing that we start looking through some
HBase traces and figure out what they could be and adding those columns by
default? It would be nice to just dynamically discover those as we get the
annotation. I know there isn't a real cost to having the columns if we don't
fill them on every request, but that's a little cruft too.
bq. it is inconvenient that we'd have "."
Its entirely possible is any annotation key we get and convert to to something
parseable (remember, they are all created as byte[]s). We probably need to
double-quote everything not phoenix sourced, just to be sure. And how do we
make sure its not from phoenix? Probably with some annotation prefix (at least
i don't see a another way, except for a static map of known annotations, which
is also kinda ugly)
Also, Eli raised a good issue offline about user-specified annotations. It
would be nice to type those as well, which means parsing the annotation key (or
value) for the type. But then we end up getting into a nasty situation where
its possible that a user writes two different types for the same key in the
same trace (not likely, but possible). We would have to decide if we want to
support externally specified types and then
> Add typing to trace annotations
> -------------------------------
>
> Key: PHOENIX-1241
> URL: https://issues.apache.org/jira/browse/PHOENIX-1241
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0, 4.1.1
> Reporter: Jesse Yates
> Fix For: 5.0.0, 4.1.1
>
>
> Currently traces only support storing string valued annotations - this works
> for known trace sources. However, phoenix will have trace annotations with
> specific types. We can improve the storage format to know about these custom
> types, rather than just storing strings, making the query interface more
> powerful.
> See PHOENIX-1226 for more discussion
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
