Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17407242
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -220,6 +227,23 @@
HConstants.VERSIONS + "=" +
MetaDataProtocol.DEFAULT_MAX_META_DATA_VERSIONS + ",\n" +
HTableDescriptor.SPLIT_POLICY + "='" +
MetaDataSplitPolicy.class.getName() + "'\n";
+ public static final String CREATE_STATS_TABLE_METADATA =
+ "CREATE TABLE " + SYSTEM_CATALOG_SCHEMA + ".\"" +
SYSTEM_STATS_TABLE + "\"(\n" +
+ // PK columns
+ TABLE_SCHEM + " VARCHAR NULL," +
+ TABLE_NAME + " VARCHAR NOT NULL," +
+ COLUMN_NAME + " VARCHAR," +
--- End diff --
Also, sorry to flip/flop on this, but I think it's going to be easier if we
store the physical table name as a single field here instead of TABLE_SCHEM and
TABLE_NAME. How about calling it PHYSICAL_NAME? Then, from MetaDataClient (see
my comments there), you can just pass in the physicalName you get from the
PTable directly (no need to take it apart and put it back together).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
