Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/12#discussion_r17408891
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/hbase/schema/stats/StatsCollectorIT.java
 ---
    @@ -0,0 +1,245 @@
    +package org.apache.phoenix.hbase.schema.stats;
    +
    +import static org.apache.phoenix.util.PhoenixRuntime.JDBC_PROTOCOL;
    +import static 
org.apache.phoenix.util.PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR;
    +import static 
org.apache.phoenix.util.PhoenixRuntime.JDBC_PROTOCOL_TERMINATOR;
    +import static 
org.apache.phoenix.util.PhoenixRuntime.PHOENIX_TEST_DRIVER_URL_PARAM;
    +import static org.apache.phoenix.util.TestUtil.LOCALHOST;
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.assertTrue;
    +
    +import java.io.IOException;
    +import java.sql.Array;
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Map;
    +import java.util.Properties;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HBaseConfiguration;
    +import org.apache.hadoop.hbase.HBaseTestingUtility;
    +import org.apache.phoenix.end2end.BaseHBaseManagedTimeIT;
    +import org.apache.phoenix.end2end.HBaseManagedTimeTest;
    +import org.apache.phoenix.query.QueryServices;
    +import org.apache.phoenix.schema.stat.StatisticsConstants;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.apache.phoenix.util.ReadOnlyProps;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +
    +import com.google.common.collect.Maps;
    +
    +@Category(HBaseManagedTimeTest.class)
    +public class StatsCollectorIT extends BaseHBaseManagedTimeIT {
    +    private static String url;
    +    private static HBaseTestingUtility util;
    +    private static int frequency = 4000;
    +
    +    @BeforeClass
    +    public static void doSetup() throws Exception {
    +        Configuration conf = HBaseConfiguration.create();
    +        setUpConfigForMiniCluster(conf);
    +        conf.setInt("hbase.client.retries.number", 2);
    +        conf.setInt("hbase.client.pause", 5000);
    +        
conf.setLong(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_TIME_ATTRIB, 
0);
    +        util = new HBaseTestingUtility(conf);
    +        util.startMiniCluster();
    +        String clientPort = 
util.getConfiguration().get(QueryServices.ZOOKEEPER_PORT_ATTRIB);
    +        url = JDBC_PROTOCOL + JDBC_PROTOCOL_SEPARATOR + LOCALHOST + 
JDBC_PROTOCOL_SEPARATOR + clientPort
    +                + JDBC_PROTOCOL_TERMINATOR + PHOENIX_TEST_DRIVER_URL_PARAM;
    +        int targetQueryConcurrency = 3;
    +        int maxQueryConcurrency = 5;
    +        int histogramDepth = 60;
    +        Map<String, String> props = Maps.newHashMapWithExpectedSize(3);
    +        props.put(QueryServices.MAX_QUERY_CONCURRENCY_ATTRIB, 
Integer.toString(maxQueryConcurrency));
    +        props.put(QueryServices.TARGET_QUERY_CONCURRENCY_ATTRIB, 
Integer.toString(targetQueryConcurrency));
    +        props.put(StatisticsConstants.HISTOGRAM_BYTE_DEPTH_CONF_KEY, 
Integer.toString(histogramDepth));
    +        props.put(QueryServices.MAX_INTRA_REGION_PARALLELIZATION_ATTRIB, 
Integer.toString(Integer.MAX_VALUE));
    +        props.put(QueryServices.STATS_UPDATE_FREQ_MS_ATTRIB, 
Integer.toString(frequency));
    +        driver = initAndRegisterDriver(url, new 
ReadOnlyProps(props.entrySet().iterator()));
    +    }
    +
    +    @AfterClass
    +    public static void tearDown() throws Exception {
    +        dropTables();
    +        util.shutdownMiniCluster();
    +    }
    +
    +    @Test
    +    public void testUpdateStatsForTheTable() throws Throwable {
    --- End diff --
    
    I am just ensuring that the tests run with different tables and with 
individual ANALYZE calls, we are able to get results on both the tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to