Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17709287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -462,6 +471,59 @@ public MutationState createTable(CreateTableStatement
statement, byte[][] splits
return connection.getQueryServices().updateData(plan);
}
+ public MutationState updateStatistics(UpdateStatisticsStatement
updateStatisticsStmt) throws SQLException {
+ TableName tableNameNode =
updateStatisticsStmt.getTable().getName();
+ String tableName = tableNameNode.getTableName();
+ // Check before updating the stats if we have reached the
configured time to reupdate the stats once again
+ long minTimeForStatsUpdate =
connection.getQueryServices().getProps()
+ .getLong(StatisticsConstants.MIN_STATS_FREQ_UPDATION,
StatisticsConstants.DEFAULT_STATS_FREQ_UPDATION);
+ ColumnResolver resolver =
FromCompiler.getResolver(updateStatisticsStmt, connection);
+ PTable table = resolver.getTables().get(0).getTable();
+ PName physicalName = table.getPhysicalName();
+ byte[] tenantIdBytes = ByteUtil.EMPTY_BYTE_ARRAY;
+ KeyRange analyzeRange = KeyRange.EVERYTHING_RANGE;
+ if (connection.getTenantId() != null && table.getBucketNum() ==
null) {
+ tenantIdBytes = connection.getTenantId().getBytes();
+ List<List<KeyRange>> tenantIdKeyRanges =
Collections.singletonList(Collections.singletonList(KeyRange
+ .getKeyRange(tenantIdBytes)));
+ byte[] lowerRange =
ScanUtil.getMinKey(table.getRowKeySchema(), tenantIdKeyRanges,
+ ScanUtil.SINGLE_COLUMN_SLOT_SPAN);
+ byte[] upperRange =
ScanUtil.getMaxKey(table.getRowKeySchema(), tenantIdKeyRanges,
+ ScanUtil.SINGLE_COLUMN_SLOT_SPAN);
+ analyzeRange = KeyRange.getKeyRange(lowerRange, upperRange);
+ }
+ String schemaName = tableNameNode.getSchemaName();
+ byte[] schemaBytes = ByteUtil.EMPTY_BYTE_ARRAY;
+ if(schemaName != null) {
+ schemaBytes = tableNameNode.getSchemaName().getBytes();
+ }
+ Long scn = connection.getSCN();
+ // Always invalidate the cache
+ long clientTS = connection.getSCN() == null ?
HConstants.LATEST_TIMESTAMP : scn;
+ connection.getQueryServices().clearCacheForTable(tenantIdBytes,
schemaBytes,
+ tableNameNode.getTableName().getBytes(), clientTS);
--- End diff --
Here, just use table.getSchemaName().getBytes() for schemaName and
table.getTableName().getBytes(). No need for any null checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
