Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17709620
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
@@ -851,14 +895,18 @@ public static PTable
createFromProto(PTableProtos.PTable table) {
for (PTableProtos.PTable curPTableProto : table.getIndexesList()) {
indexes.add(createFromProto(curPTableProto));
}
+ List<PColumnFamily> columnFamilies =
Lists.newArrayListWithExpectedSize(table.getColumnfamiliesCount());
--- End diff --
The PColumnFamily are created in the init() method. The columns are already
serialized by PTable - you don't want to serialize them again for
PColumnFamily. We'll likely run into backward compat issues for newer servers
and older clients if you go this route. Instead, just serialize enough info so
that you can create a PTableStats object when you deserialize. Then pass in the
PTableStats object into the init() method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
