[ https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148820#comment-14148820 ]
ASF GitHub Bot commented on PHOENIX-1198: ----------------------------------------- GitHub user elilevine opened a pull request: https://github.com/apache/phoenix/pull/21 Added custom annotations to logs in query-related functionality in client- and server-side code for PHOENIX-1198 @JamesRTaylor, take a look when you get a chance. Shouldn't be anything controversial. Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/elilevine/apache-phoenix logging-branch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 ---- commit 0aadefe11a9d6e5fb51c89505bcef3b849f99f67 Author: Eli Levine <elilev...@apache.org> Date: 2014-09-26T05:22:26Z Added custom annotations to query-related log lines, both client- and server-side for PHOENIX-1198 commit e34b8c33a067ace5316fd07c8c503f602041e379 Author: Eli Levine <elilev...@apache.org> Date: 2014-09-26T05:46:19Z Added toString() to a bunch of iterators that were missing it to improve logging output for PHOENIX-1198 ---- > Add ability to pass custom annotations to be added to log lines > --------------------------------------------------------------- > > Key: PHOENIX-1198 > URL: https://issues.apache.org/jira/browse/PHOENIX-1198 > Project: Phoenix > Issue Type: Improvement > Reporter: Eli Levine > Assignee: Eli Levine > Fix For: 5.0.0, 4.1 > > > These tags can be passed in either when creating connections or calling > upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same > mechanism for passing in values to be logged/traced. -- This message was sent by Atlassian JIRA (v6.3.4#6332)