[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148824#comment-14148824
]
ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/21#discussion_r18074918
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java
---
@@ -180,5 +181,12 @@ private boolean rowKeyChanged(Tuple newTuple) {
return Bytes.compareTo(currentKey, offset, length,
lastKey.get(), lastKey.getOffset(), lastKey.getLength()) != 0;
}
+
+ @Override
+ public String toString() {
--- End diff --
Added a bunch of toString() methods for objects that might be logged.
> Add ability to pass custom annotations to be added to log lines
> ---------------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
