[
https://issues.apache.org/jira/browse/PHOENIX-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162262#comment-14162262
]
James Taylor commented on PHOENIX-1297:
---------------------------------------
Looking good, [~samarthjain]. Here's some feedback on some minor stuff:
- Instead of using BOOLEAN[] as the type name, can we use BOOLEAN ARRAY
instead? I think there's one place in your code that you're checking for (or
adding) "[]". Can you change that to use a newly defined PDataType.ARRAY_NAME
static constant?
- Your String getQuotedFullColumnName(PColumn pCol) seems generally useful. How
about adding that to SchemaUtil instead? Then your QueryOptimizerTest
.addQuotes(String familyName, String columnNames) can perhaps use that instead?
> Adding utility methods to get primary key information from the optimized
> query plan
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-1297
> URL: https://issues.apache.org/jira/browse/PHOENIX-1297
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.2, 3.2
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1297.patch, PHOENIX-1297_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
