[
https://issues.apache.org/jira/browse/PHOENIX-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175450#comment-14175450
]
James Taylor commented on PHOENIX-1297:
---------------------------------------
Looks good, [~samarthjain]. One minor item: you don't need to strip the quotes
here, as SchemaUtil.normalizeIdentifier() does that for you, and in the off
chance that there's a double quote in the name, your stripping would cause
problems.
{code}
+ // normalize and remove quotes from family and column names before
looking up.
+ familyName = stripQuotes(SchemaUtil.normalizeIdentifier(familyName));
+ columnName = stripQuotes(SchemaUtil.normalizeIdentifier(columnName));
{code}
If it's ok with you, I can make this change when I commit.
> Adding utility methods to get primary key information from the optimized
> query plan
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-1297
> URL: https://issues.apache.org/jira/browse/PHOENIX-1297
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.2, 3.2
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1297_v2.patch, PHOENIX-1297_v3.patch,
> PHOENIX-1297_v4.patch, PHOENIX-1297_v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
