[
https://issues.apache.org/jira/browse/PHOENIX-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200715#comment-14200715
]
James Taylor commented on PHOENIX-1407:
---------------------------------------
Thanks for the fix for PHOENIX-1404, [~gabriel.reid]. Would you have time to
fix this related one too? It should be as simple as adding in
QueryCompiler.compileSingleFlatQuery() the following call:
{code}
scan.setCaching(statement.getFetchSize());
{code}
A couple of unit tests in WhereCompilerTest would be good too, to verify that
the scan has 1) the default cache size of
QueryServicesOptions.DEFAULT_SCAN_CACHE_SIZE if Statement.setFetchSize() wasn't
called and 2) the cache size specified on the Statement if setFetchSize() was
called.
> PhoenixStatement.getFetchSize() appears to never be used
> --------------------------------------------------------
>
> Key: PHOENIX-1407
> URL: https://issues.apache.org/jira/browse/PHOENIX-1407
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
>
> We should use PhoenixStatement.getFetchSize() or potentially
> PhoenixResultSet.getFetchSize() to determine what to use for
> Scan.setCaching(). I'm not seeing this done currently, but maybe I'm just
> missing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
