[
https://issues.apache.org/jira/browse/PHOENIX-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-1467:
----------------------------------
Attachment: PHOENIX-1467.patch
Patch to update JUnit version to 4.12-beta-3 to take advantage of the fact that
@Category annotation is now inheritable. This removes the need to annotate each
IT test with the right category (as long as they inherit from the base classes
mentioned in JIRA). IT tests not extending the mentioned base classes still
would need to provide appropriate @Category annotation.
Additionally, the patch also updates the plugin versions for surefire, failsafe
and mvn eclipse.
It also updates the mvn assembly plugin version. I have seen intermittent
errors like these:
Failed to create assembly: Error creating assembly archive src: Problem
creating TAR: request to write '8192' bytes exceeds size in header of
'1438101504' bytes
with the 2.4 plugin. That seems to be fixed with 2.5.2.
[~jamestaylor] please review.
> Upgrade to 4.12 Junit and update tests by removing @Category annotation
> -----------------------------------------------------------------------
>
> Key: PHOENIX-1467
> URL: https://issues.apache.org/jira/browse/PHOENIX-1467
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1467.patch
>
>
> The 4.12 Junit release makes the @Category annotation inheritable. This means
> we no longer need to annotate each our test classes with category annotations
> like @Category(NeedsOwnMiniClusterTest.class).
> Test classes that inherit from one of these base test classes -
> BaseOwnClusterIT, BaseClientManagedTimeIT and BaseHBaseManagedTimeIT will get
> automatically categorized into @Category(NeedsOwnMiniClusterTest.class),
> @Category(ClientManagedTimeTest.class) and
> @Category(HBaseManagedTimeTest.class) respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
