[
https://issues.apache.org/jira/browse/PHOENIX-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223522#comment-14223522
]
James Taylor commented on PHOENIX-1467:
---------------------------------------
Excellent, [~samarthjain]. Thanks for following up on this. This will
definitely prevent mismatches between the derived class and the annotation,
removing this as a cause of test flakiness which has bitten us quite a few
times. I'll get this committed later today unless anyone has objections.
> Upgrade to 4.12 Junit and update tests by removing @Category annotation
> -----------------------------------------------------------------------
>
> Key: PHOENIX-1467
> URL: https://issues.apache.org/jira/browse/PHOENIX-1467
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1467.patch
>
>
> The 4.12 Junit release makes the @Category annotation inheritable. This means
> we no longer need to annotate each our test classes with category annotations
> like @Category(NeedsOwnMiniClusterTest.class).
> Test classes that inherit from one of these base test classes -
> BaseOwnClusterIT, BaseClientManagedTimeIT and BaseHBaseManagedTimeIT will get
> automatically categorized into @Category(NeedsOwnMiniClusterTest.class),
> @Category(ClientManagedTimeTest.class) and
> @Category(HBaseManagedTimeTest.class) respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
