[ 
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252423#comment-14252423
 ] 

Lars Hofhansl commented on PHOENIX-1514:
----------------------------------------

OK... A non-committal +0 from me :)
I've seen "so called refactors" break things one time too often in my life. 
Indeed is does not violate any of the contracts that James stated.


> Break up PDataType Enum
> -----------------------
>
>                 Key: PHOENIX-1514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1514
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch, 
> PHOENIX-1514.02.patch, PHOENIX-1514.04.patch, PHOENIX-1514.05.branch-4.patch, 
> PHOENIX-1514.05.patch, hung-phoenix-verify.txt, stack.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up 
> the PDataType enum into an interface. This will pave the way for more 
> flexibility going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to