[jira] [Commented] (PHOENIX-1409) Allow ALTER TABLE SET command to update HTableDescriptor and HColumnDescriptor properties

Mon, 22 Dec 2014 13:04:01 -0800

    [ 
https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256190#comment-14256190
 ] 

Alicia Ying Shu commented on PHOENIX-1409:
------------------------------------------

-                try {
-                    
-                    conn.createStatement().execute("ALTER TABLE TEST_TABLE SET 
IN_MEMORY=false");
-                    fail("Should have caught exception.");
-                    
-                } catch (SQLException e) {
-                    assertTrue(e.getMessage(), e.getMessage().contains("ERROR 
1025 (42Y84): Unsupported property set in ALTER TABLE command."));
-                } 
-        }finally {

There is a positive test in the patch for this.

>Looks like your indenting is off here, as there should be no diff (in 
>AlterTableIT):
The original file had indenting issue. Just to correct it.


> Allow ALTER TABLE <table> SET command to update HTableDescriptor and 
> HColumnDescriptor properties
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1409
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1409
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.2
>            Reporter: James Taylor
>            Assignee: Alicia Ying Shu
>         Attachments: Phoenix-1409-v1.patch, Phoenix-1409.patch, WIP.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and 
> HColumnDescriptor properties through the ALTER TABLE <table> SET command. 
> It'd just be a matter of passing these properties through the existing 
> methods, as we support this for CREATE TABLE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to