[
https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262020#comment-14262020
]
Alicia Ying Shu commented on PHOENIX-1409:
------------------------------------------
[~jamestaylor], [~samarth.j...@gmail.com], attached is the updated patch that
addressed the following issues:
1) Thanks Samarth for suggested changes in Phoenix-1409-v3.patch. However there
is a regression on setting TTL for default column family. fixed that and added
a test case.
2) For the new modifyTable API in ConnectionQueryServices, removed HBaseAdmin
as an argument.
3) Method modifyTableProps now returns the HTableDescriptor so no need to get
the HTableDescriptor again for setTTLForNewColumnFamilies.
4) For the new Property class, define the PropertyValidator.validate as: void
validate(TableProperty property, boolean isMutating, String familyName,
PTableType tableType) throws SQLException;
5) Reverted unrelated test changes.
> Allow ALTER TABLE <table> SET command to update HTableDescriptor and
> HColumnDescriptor properties
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1409
> URL: https://issues.apache.org/jira/browse/PHOENIX-1409
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.2
> Reporter: James Taylor
> Assignee: Alicia Ying Shu
> Attachments: PHOENIX-1409-v3.patch, Phoenix-1409-v1.patch,
> Phoenix-1409-v4.patch, Phoenix-1409.patch, WIP.patch, phoenix-1409-v2.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and
> HColumnDescriptor properties through the ALTER TABLE <table> SET command.
> It'd just be a matter of passing these properties through the existing
> methods, as we support this for CREATE TABLE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
